nostr/nips
1
0
Fork 0
mirror of https://github.com/nostr-protocol/nips.git synced 2024-11-09 22:09:06 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

NIP-34: clarify cover letters

Browse Source 
remove cover letters from 'possible things to be added later' and
add a clarification that can they can be added through patches
This commit is contained in:
DanConwayDev 2024-03-07 09:20:25 +00:00 committed by fiatjaf_
parent 8225a018c7
commit 0b62729e31
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
34.md
View File

@ -69,6 +69,8 @@ The first patch revision in a patch revision SHOULD include a NIP-10 `e` `reply`
} }
``` ```
The first patch in a series MAY be a cover letter in the format produced by `git format-patch`.
## Issues ## Issues
Issues are Markdown text that is just human-readable conversational threads related to the repository: bug reports, feature requests, questions or comments of any kind. Like patches, these SHOULD be sent to the relays specified in that repository's announcement event's `"relays"` tag. Issues are Markdown text that is just human-readable conversational threads related to the repository: bug reports, feature requests, questions or comments of any kind. Like patches, these SHOULD be sent to the relays specified in that repository's announcement event's `"relays"` tag.
@ -108,5 +110,4 @@ Replies are also Markdown text. The difference is that they MUST be issued as re
- "status" kind (for letting people know a patch was merged or an issue was fixed or won't be fixed) - "status" kind (for letting people know a patch was merged or an issue was fixed or won't be fixed)
- "branch merge" kind (specifying a URL from where to fetch the branch to be merged) - "branch merge" kind (specifying a URL from where to fetch the branch to be merged)
- "cover letter" kind (to which multiple patches can refer and serve as a unifying layer to them)
- inline file comments kind (we probably need one for patches and a different one for merged files) - inline file comments kind (we probably need one for patches and a different one for merged files)