mirror of
https://github.com/nostr-protocol/nips.git
synced 2024-12-22 08:25:53 -05:00
NIP-34: add status events
merge-commit and applied-commit-id tags enable discussion of patches to be mapped to lines of code accepted into the master branch
This commit is contained in:
parent
0b62729e31
commit
403b5199a4
40
34.md
40
34.md
|
@ -106,8 +106,46 @@ Replies are also Markdown text. The difference is that they MUST be issued as re
|
||||||
}
|
}
|
||||||
```
|
```
|
||||||
|
|
||||||
|
## Status
|
||||||
|
|
||||||
|
Root Patches and Issues have a Status that defaults to 'Open' and can be set by issuing Status events.
|
||||||
|
|
||||||
|
```jsonc
|
||||||
|
{
|
||||||
|
"kind": 1630, // Open
|
||||||
|
"kind": 1631, // Applied / Merged for Patches; Resolved for Issues
|
||||||
|
"kind": 1632, // Closed
|
||||||
|
"kind": 1633, // Draft
|
||||||
|
"content": "<markdown text>",
|
||||||
|
"tags": [
|
||||||
|
["e", "<issue-or-original-root-patch-id-hex>", "", "root"],
|
||||||
|
["e", "<accepted-revision-root-id-hex>", "", "reply"], // for when revisions applied
|
||||||
|
["p", "<repository-owner>"],
|
||||||
|
["p", "<root-event-author>"],
|
||||||
|
["p", "<revision-author>"],
|
||||||
|
|
||||||
|
// optional for improved subscription filter efficency
|
||||||
|
["a", "30617:<base-repo-owner-pubkey>:<base-repo-id>", "<relay-url>"],
|
||||||
|
["r", "<earliest-unique-commit-id-of-repo>"]
|
||||||
|
|
||||||
|
// optional for `1631` status
|
||||||
|
["e", "<applied-or-merged-patch-event-id>", "", "mention"], // for each
|
||||||
|
// when merged
|
||||||
|
["merge-commit", "<merge-commit-id>"]
|
||||||
|
["r", "<merge-commit-id>"]
|
||||||
|
// when applied
|
||||||
|
["applied-as-commits", "<commit-id-in-master-branch>", ...]
|
||||||
|
["r", "<applied-commit-id>"] // for each
|
||||||
|
]
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
The Status event with the largest created_at date is valid.
|
||||||
|
|
||||||
|
The Status of a patch-revision defaults to either that of the root-patch, or `1632` (Closed) if the root-patch's Status is `1631` and the patch-revision isn't tagged in the `1631` event.
|
||||||
|
|
||||||
|
|
||||||
## Possible things to be added later
|
## Possible things to be added later
|
||||||
|
|
||||||
- "status" kind (for letting people know a patch was merged or an issue was fixed or won't be fixed)
|
|
||||||
- "branch merge" kind (specifying a URL from where to fetch the branch to be merged)
|
- "branch merge" kind (specifying a URL from where to fetch the branch to be merged)
|
||||||
- inline file comments kind (we probably need one for patches and a different one for merged files)
|
- inline file comments kind (we probably need one for patches and a different one for merged files)
|
||||||
|
|
Loading…
Reference in New Issue
Block a user