nostr/nips
1
0
Fork 0
mirror of https://github.com/nostr-protocol/nips.git synced 2024-11-12 23:19:08 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix 34asc when created_at is absent

Browse Source
This commit is contained in:
arthurfranca 2023-06-27 12:10:35 -03:00
parent 537ad9f455
commit 739a65dd78
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
34asc.md
View File

@ -8,6 +8,11 @@ Ascending
Events with older `created_at` are retrieved first.
## Motivation
For thread building it may better showing first comments at top to make it easier to understand
the context of newer comments.
## Implementation
`Relay` computes `nip34asc` field once upon receiving the event.
@ -26,8 +31,10 @@ const maxSecondsLength = maxTs.toString().length
function getNip34asc (createdAt, id = '') {
// The id length must always be the same to not affect sorting
// All relays must use the same length
if (id.length !== 64) { throw new Error('Wrong id length') }
let seconds = Math.trunc(createdAt) // Make sure it is int instead of float
if (Number.isNaN(seconds)) { throw new Error('Wrong createdAt') }
seconds = Math.max(seconds, -maxDateNowSeconds) // Keep min limit
seconds = Math.min(seconds, maxDateNowSeconds) // Keep max limit
// Allow negative createdAt but remove minus sign